From 01e386388054e043114818ab8b1f48739983e99d Mon Sep 17 00:00:00 2001
From: cozis <heibyob@gmail.com>
Date: Fri, 14 Jan 2022 01:05:01 +0100
Subject: [PATCH] added tests and fixed bug

---
 lina.c | 13 ++++-----
 test.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 89 insertions(+), 10 deletions(-)

diff --git a/lina.c b/lina.c
index 92670a8..a0c6aef 100644
--- a/lina.c
+++ b/lina.c
@@ -20,7 +20,7 @@ void lina_dot(double *A, double *B, double *C, int m, int n, int l){
         for(int k=0; k < l; k++){
 
             double pos = 0;
-            
+
             //Iteration over the single B column for executing the product of sum
             for(int j=0; j < n; j++)
                 pos += A[i * n + j] * B[j * l + k];
@@ -71,14 +71,11 @@ void lina_transpose(double *A, double *B, int m, int n){
 
     memcpy(support, A, sizeof(*support) * m * n);
 
-    for(int i=0;i<n;i++){
+    for(int i = 0; i < n; i++)
+        
+        for(int j = 0; j < m; j++)
 
-        for(int j=0;j<m;j++){
-
-            B[i*m + j] = support[i*m + j];
-        }
-    
-    }
+            B[j*n + i] = support[i*m + j];
 
     free(support);
 }
\ No newline at end of file
diff --git a/test.c b/test.c
index 13edf09..937c6fe 100644
--- a/test.c
+++ b/test.c
@@ -4,7 +4,7 @@
 #include "lina.h"
 
 //Print the matrix A with size m by n
-void pmatrix(FILE *fp, double *A, int m, int n);
+static void pmatrix(FILE *fp, double *A, int m, int n);
 
 struct {
 	double A[9], // Left argument
@@ -50,6 +50,60 @@ struct {
 	},
 };
 
+struct {
+	double A[9], B[9];
+} transp_tests[] = {
+	{
+		.A = {
+			1, 0, 0,
+			0, 2, 0,
+			0, 0, 3,
+		},
+		.B = {
+			1, 0, 0,
+			0, 2, 0,
+			0, 0, 3,
+		},
+	},
+	{
+		.A = {
+			1, 2, 3,
+			0, 0, 0,
+			0, 0, 0,
+		},
+		.B = {
+			1, 0, 0,
+			2, 0, 0,
+			3, 0, 0,
+		},
+	},
+	{
+		.A = {
+			0, 1, 0,
+			0, 2, 0,
+			0, 3, 0,
+		},
+		.B = {
+			0, 0, 0,
+			1, 2, 3,
+			0, 0, 0,
+		},
+	},
+	{
+		.A = {
+			0, 0, 1,
+			0, 0, 2,
+			0, 0, 3,
+		},
+		.B = {
+			0, 0, 0,
+			0, 0, 0,
+			1, 2, 3,
+		},
+	},
+
+};
+
 int main()
 {
 	// Evaluate dot product tests.
@@ -106,10 +160,38 @@ int main()
 			}
 		fprintf(stderr, "\n\t%d scalings out of %d were succesful.\n\n", scale_passed, scale_total);
 	}
+
+	// Evaluate transposition tests.
+	{
+		int transp_passed = 0;
+		int transp_total  = sizeof(transp_tests) / sizeof(*transp_tests);
+
+		for(int i = 0; i < transp_total; i += 1)
+			{
+				double R[9];
+
+				lina_transpose(transp_tests[i].A, R, 3, 3);
+
+				if(!memcmp(R, transp_tests[i].B, sizeof(R)))
+					{
+						fprintf(stderr, "Transposition test %d passed.\n", i);
+						transp_passed += 1;
+					}
+				else
+					{
+						fprintf(stderr, "Transposition test %d failed:\n  got matrix:\n\n", i);
+						pmatrix(stderr, R, 3, 3);
+						fprintf(stderr, "  instead of:\n\n");
+						pmatrix(stderr, transp_tests[i].B, 3, 3);
+					}
+			}
+		fprintf(stderr, "\n\t%d transpositions out of %d were succesful.\n\n", transp_passed, transp_total);
+	}
+
 	return 0;
 }
 
-void pmatrix(FILE *fp, double *A,int m,int n){
+static void pmatrix(FILE *fp, double *A,int m,int n){
 
 	for(int i = 0; i<m; i++){
 		fprintf(fp, "    | ");